Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode all packages under dependabot config #18

Merged
merged 3 commits into from Nov 1, 2022
Merged

Conversation

rubensf
Copy link
Member

@rubensf rubensf commented Nov 1, 2022

Dependabot doesn't inheretly find all nested package.json, and in this case it's complaining it can't find any [1]. It also doesn't support wildcards, so the hack scripts options to handle that are complex [2].

We could add some generate/lint rules to ensure the dependabot configuration is up to date, but that seems overkill for this repo.

1: https://github.com/bufbuild/connect-web-integration/network/updates/496698197
2: dependabot/dependabot-core#2178 (comment)

Dependabot doesn't inheretly find all nested package.json, and in this
case it's complaining it can't find any [1]. It also doesn't support
wildcards, so the hack scripts options to handle that are complex [2].

We could add some generate/lint rules to ensure the dependabot
configuration is up to date, but that seems overkill for this repo.

1: https://github.com/bufbuild/connect-web-integration/network/updates/496698197
2: dependabot/dependabot-core#2178 (comment)
@rubensf rubensf requested a review from smaye81 November 1, 2022 12:33
@smaye81
Copy link
Member

smaye81 commented Nov 1, 2022

Actually we may want to just manually update these ourselves. This repo (as you've discovered) has a ton of nested projects that are all separate, all with their own package.json files. The Dependabot PRs will probably be extremely onerous to handle.

Anyway we could maybe turn off Dependabot for this repo (asking from a compliance standpoint).

@rubensf
Copy link
Member Author

rubensf commented Nov 1, 2022

I think we can get away without dependabot, but I wonder if it wouldn't be useful to keep it for the reminders? There's a couple of our repos where do we exactly that - we don't even want to rely on dependabot to actually do the merges, but it's a useful tracker for "out of date" things.

@smaye81
Copy link
Member

smaye81 commented Nov 1, 2022

That works, yeah. How does it work as a reminder? Does Dependabot still create a bunch of PRs?

@rubensf
Copy link
Member Author

rubensf commented Nov 1, 2022

... Yes, I thought of it as creating a bunch of PRs 🥲

@smaye81
Copy link
Member

smaye81 commented Nov 1, 2022

Hmm ok. That seems fine I guess. The bot runs monthly so maybe it won't be too noisy. We can try it out.

Super dumb nit but could you put the list in alphabetical order by directory? It will make it much easier to add / remove things if need be.

@rubensf
Copy link
Member Author

rubensf commented Nov 1, 2022

Good ask - just made it all in alphabetical order.

If the PRs become a nuisance we can turn it off :)

Copy link
Member

@smaye81 smaye81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir.

@rubensf rubensf merged commit 897213b into main Nov 1, 2022
@rubensf rubensf deleted the rfarias/dependabot branch November 1, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants