Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map<k,v> doesn't support bigint and boolean keys #258

Closed
fubhy opened this issue Oct 26, 2022 · 4 comments
Closed

map<k,v> doesn't support bigint and boolean keys #258

fubhy opened this issue Oct 26, 2022 · 4 comments

Comments

@fubhy
Copy link
Contributor

fubhy commented Oct 26, 2022

The map<k,v> field type currently uses a simple object as a representation. However, that doesn't work for bigint keys.

Same for boolean keys. That's also theoretically supported and there's even a possible pitfall here (stringified serializing and deserializing booleans that is). So I'd personally prefer to use Map<k, v>() here unless something speaks against that?

@fubhy fubhy changed the title map<k,v> doesn't support bigint keys map<k,v> doesn't support bigint and boolean keys Oct 26, 2022
@smaye81
Copy link
Member

smaye81 commented Oct 26, 2022

Hey @fubhy. That was actually a design choice when writing the library. See our docs on maps here.

That being said, though, we are investigating whether we still want to stick with this simple object representation or instead migrate to using an ES Map. It is on our roadmap as something to decide before our v1.0 release, which should be out soon.

I'll keep this issue open until a decision is reached. Thanks for the issue, definitely on our plate to consider.

@fubhy
Copy link
Contributor Author

fubhy commented Oct 26, 2022

Sorry, I must've missed that in the docs.

@smaye81
Copy link
Member

smaye81 commented Oct 26, 2022

No worries. Something we're thinking about also.

@smaye81
Copy link
Member

smaye81 commented Dec 1, 2022

Hi @fubhy. After a lot of deliberation on this, we've decided not to switch to Map at this time and are sticking with simple objects. Apologies for any inconveniences this causes.

@smaye81 smaye81 closed this as completed Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants