Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions #86

Closed
bufdev opened this issue May 10, 2022 · 7 comments · Fixed by #666
Closed

Extensions #86

bufdev opened this issue May 10, 2022 · 7 comments · Fixed by #666

Comments

@bufdev
Copy link
Member

bufdev commented May 10, 2022

The docs say:

We implement all proto2 features, except for extensions and the text format.

I don't think we can ignore extensions - what does the core js do?

@SyrieBianco
Copy link

SyrieBianco commented May 12, 2022

Tracked internally in TCN-61

@fubhy
Copy link
Contributor

fubhy commented Oct 21, 2022

Any news on this? This is currently my main "soft" blocker for implementing message validation (using https://github.com/bufbuild/protoc-gen-validate)

connectrpc/connect-es#270

Is this being worked on or can I lend a hand here? If so, I'd love some pointers (tried to read through the code generator request => descriptor set creation code but am a bit lost to be honest :-)

EDIT:
I am able to get around this via the findCustomMessageOption for now.

@timostamm
Copy link
Member

Hey Sebastian, findCustomMessageOption() is indeed the way to go for now!

@fubhy
Copy link
Contributor

fubhy commented Oct 21, 2022

Yeah, I built my own version of that before I found that in your code :-D. Sorry for the noise.

@zfedoran
Copy link

@fubhy are you able to share what you've done to get message validation running using findCustomMessageOption()?

@rofrankel
Copy link

rofrankel commented Apr 5, 2023

Just commenting to +1 the issue - my use case would benefit from extension support (specifically, message and field options).

@timostamm
Copy link
Member

Support for extensions was just released in v1.7.0.

Extensions can be used to retrieve custom Protobuf options from descriptors, for example in a plugin. But it's not possible yet to retrieve options at runtime from generated code. We do have concrete plans for this feature though, and we'll keep the issue #397 updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants