Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Go version used with Bazel #622

Closed
Kernald opened this issue Aug 17, 2022 · 3 comments
Closed

Updating Go version used with Bazel #622

Kernald opened this issue Aug 17, 2022 · 3 comments

Comments

@Kernald
Copy link

Kernald commented Aug 17, 2022

When using pgv with Bazel, the setup kind of forces to use Go 1.15.6: https://github.com/envoyproxy/protoc-gen-validate/blob/61feee29cf191d1e4e2687adb8a0d390db7c27d9/bazel/dependency_imports.bzl#L17-L19

Go introduced support for aarch64 on macOS with 1.16, so this is effectively blocking on that arch. I'm not too familiar with Go (I'm using pgv in Kotlin mostly), are there any strong reasons not to update it? (Go 1.16 has been released in early 2021, I assume it's pretty safe to update at least to 1.16 at this point?)

@elliotmjackson
Copy link
Contributor

since #629 & v0.6.8, this has been uplifted to 1.19.1

@Kernald
Copy link
Author

Kernald commented Sep 19, 2022

Updating to 0.6.8 actually fails to compile with Bazel (I had a similar issue trying to update the Go version in 0.6.7 locally):

ERROR: /root/.cache/bazel/_bazel_root/433e348f76cbac3cc1ad104fee035fb1/external/com_github_lyft_protoc_gen_star/BUILD.bazel:3:11: GoCompilePkg external/com_github_lyft_protoc_gen_star/protoc-gen-star.a [for host] failed: (Exit 1): builder failed: error executing command bazel-out/host/bin/external/go_sdk/builder compilepkg -sdk external/go_sdk -installsuffix linux_amd64 -src external/com_github_lyft_protoc_gen_star/artifact.go -src ... (remaining 79 arguments skipped)
Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
compilepkg: missing strict dependencies:
	/root/.cache/bazel/_bazel_root/433e348f76cbac3cc1ad104fee035fb1/sandbox/linux-sandbox/113/execroot/fr_enoent/external/com_github_lyft_protoc_gen_star/init_option.go: import of "github.com/spf13/afero"
	/root/.cache/bazel/_bazel_root/433e348f76cbac3cc1ad104fee035fb1/sandbox/linux-sandbox/113/execroot/fr_enoent/external/com_github_lyft_protoc_gen_star/persister.go: import of "github.com/spf13/afero"
No dependencies were provided.
Check that imports in Go sources match importpath attributes in deps.

@Kernald
Copy link
Author

Kernald commented Sep 20, 2022

Opened #636 for visibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants