Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for videos. #12

Closed
viktorgardart opened this issue Mar 26, 2016 · 4 comments
Closed

Support for videos. #12

viktorgardart opened this issue Mar 26, 2016 · 4 comments
Labels

Comments

@viktorgardart
Copy link

viktorgardart commented Mar 26, 2016

Will you support videos in the feature? 馃槂

@ay8s ay8s added the feature label Mar 26, 2016
@DreamingInBinary
Copy link
Contributor

Good one - I'll think on this one and get back to you with a better answer :).

If we do, I definitely want it to be as easy to use technically speaking like it is now 馃憤

@viktorgardart
Copy link
Author

Awesome! 馃憣

@ezhes
Copy link

ezhes commented Jul 6, 2018

I needed this so I made a really bad fork. Code is glued together with glitter everywhere.

https://github.com/shusain93/buffer-ios-image-viewer

I also added some other features like a caption interface so you can have both a title and caption displayed alongside each photo.

To use my addons just point the cocoa pod at my repo and use EEPhoto instead of a string or URL or whatever. EEPhoto has a url and a title/description attribute which are read for creating the caption view. Set those to nil to disable the view.

Again, glued together. You've been warned.

@DreamingInBinary
Copy link
Contributor

DreamingInBinary commented Jul 6, 2018

Thanks for sharing @shusain93 - unfortunately we haven't had a business case for video support in this project as we use iOS' APIs to display video in Buffer. @viktorgardart maybe his fork might meet your needs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants