Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions before contributing #65

Closed
blackholegalaxy opened this issue Feb 2, 2019 · 5 comments
Closed

Questions before contributing #65

blackholegalaxy opened this issue Feb 2, 2019 · 5 comments

Comments

@blackholegalaxy
Copy link

blackholegalaxy commented Feb 2, 2019

I'd like to add some features on this package, but I have some questions before contributing.

  1. Could you explain why we initialize a global tunnel in src/verdaccio.js?

  2. I see despite the fact we use verdaccio 3.x in package.json dependencies, we build docker image using 4.x-next base verdaccio docker image. Could this cause instability because we build a plugin for an older version of verdaccio than the one used in the base docker image?

@blackholegalaxy blackholegalaxy changed the title What is the point to open a global tunnel? Questions before contributing Feb 3, 2019
@dlouzan
Copy link
Collaborator

dlouzan commented Feb 4, 2019

Hello, thanks for participating in the project!

  1. The global tunnel is used for compatibility with corporate environments, where internal proxies are used. With no explicit configuration, it will use the http(s)_proxy variables from the environment (see the official docs).
  2. The docker image is built based on 4.x because there's heavy refactoring of the docker image in verdaccio 4.x and we built on top of it. @juanpicado has promised to keep 4.x quite stable and shouldn't be long for a release (or so I hope :-)

@dlouzan
Copy link
Collaborator

dlouzan commented Feb 4, 2019

Sorry I didn't fully answer your plugins question: yes, that might be the case. Although as of today we hadn't found any issues, it could happen. I'll open an issue to track this.

@juanpicado
Copy link
Collaborator

has promised to keep 4.x quite stable and shouldn't be long for a release (or so I hope :-)

My soul was just sold 😆 . Yes, hopefully we finish the UI along February and couple of things and we can launch a beta with no further additions for a month. Then, big release.

@blackholegalaxy
Copy link
Author

blackholegalaxy commented Feb 4, 2019

Thanks for explainations! In the meantime, I will try to build a Docker image on top of 3.x version, because my company is always afraid of potential incompatibilities. Will watch for v4 and will try to add my planned features on v4.x.

@bufferoverflow
Copy link
Owner

closing this as we are on 4 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants