Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.2 totally broken #25

Closed
levino opened this issue Oct 12, 2020 · 12 comments
Closed

Release 2.1.2 totally broken #25

levino opened this issue Oct 12, 2020 · 12 comments

Comments

@levino
Copy link

levino commented Oct 12, 2020

Release 2.1.2 is totally broken. Check the code. It looks like the person publishing this forgot to build before upload to npm. Only the TS files were uploaded, but none of the JS files in dist/. The package now is totally unusable because the dist/index.js is missing.

Also the version makes little sense to me. The last version before was 2.0.2 so the next "feature"-version should be 2.1.0 not 2.1.2.

The build step should be added as a prepublish or prepublishOnly step. Also the TS files should not be uploaded anymore and therefore removed from the files entry in the package.json.

"src/middleware",

@HugoMario
Copy link
Collaborator

thanks @levino for reporting this, you are right about versioning, but i guess we should keep it this way now to avoid more confuse

@vnaganathan-conga
Copy link

@levino is correct. @HugoMario There is no dist/index.js even though the package.json refers to it. So our swagger API docs are broken. Please withdraw the 2.1.2 release or fix it asap and release the correct version.

@levino
Copy link
Author

levino commented Oct 14, 2020

As a workaround you can pin the version to 2.0.2 in your local dependencies until a patch is released.

I agree that 2.1.2 should be unpublished immediately to reduce wasted dev time for others.

@vnaganathan-conga
Copy link

@levino - yes we will pin it down. I cannot believe the unproductive hours I spent troubleshooting the various parts of my app (as i assumed an npm package would be the last suspect). 2.1.2 should be taken down asap.

@levino
Copy link
Author

levino commented Oct 14, 2020

Stuff like this happens. I am grateful for all the free and great software supplied by folks like the maintainers of this project here. But still now one needs to act quickly and unpublish to avoid further fallout. Release of 2.1.3 can then be done carefully and calmly.

@vnaganathan-conga
Copy link

Totally agree. I am thankful to the wonderful work the authors of this package have done! Looking for 2.1.3 soon

@nishantshah-me
Copy link

Getting an error - module could not found.

@thomasgainant
Copy link

Still getting a module not found error, even though the package is downgraded to 2.0.2

@levino
Copy link
Author

levino commented Oct 28, 2020

Show a repo with a failing test please.

@thomasgainant
Copy link

Forgot to remove the "^" in package.json. Typed "oas3-tools": "2.0.2" instead of "oas3-tools": "^2.0.2", in dependencies and the problem was solved

@HugoMario
Copy link
Collaborator

sorry guys for delay, i've just pushed 2.1.3 version with fix.

@levino
Copy link
Author

levino commented Nov 15, 2020

Sorry, forgot to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants