Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some 100 Continue responses not correctly handled, resulting in lost POST/PUT requests #1158

Open
bruce34 opened this issue Jan 24, 2023 · 1 comment

Comments

@bruce34
Copy link
Contributor

bruce34 commented Jan 24, 2023

As commented on issue 1028, we are seeing that on upgrading from 1.0.0rc2 to 1.3.3 we are losing POST traffic that contains a client header of:
Expect: 100-continue
and a server response of:
HTTP/1.1 100 (note the space after 100)

The code here assumes the response from the server will be exactly 25 bytes long (i.e. HTTP/1.1 100 Continue) but any reason phrase, and hence different lengths, should be allowed.

I could perhaps have a shot at generating a pull request to fix this, but I will need help as to where to add this to the code - currently the p.Ack addition is done without knowledge of what the server responded with.

@rsteppac
Copy link

rsteppac commented Feb 22, 2023

Same here, even though Jetty responds with HTTP/1.1 100 Continue; most of our clients use a 100-continue expectation for SOAP requests, but gor (v1.3.3 ) would only capture the small fraction of requests that do not use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants