Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File format description is outdated #1234

Open
sabi0 opened this issue Dec 11, 2023 · 1 comment
Open

File format description is outdated #1234

sabi0 opened this issue Dec 11, 2023 · 1 comment

Comments

@sabi0
Copy link

sabi0 commented Dec 11, 2023

The "File format" section on wiki is outdated
https://github.com/buger/goreplay/wiki/Saving-and-Replaying-from-file#file-format

  1. A "meta information" line is missing before the second request (POST) in the example.

  2. Documentation describes only three "meta information" values: payload type, request ID, timestamp. But the recorded files have four:

1 beb21f410a93305bf711861e 1678172411997745000 28000
  1. Timestamp unit is not specified in the documentation. Example ("127345969") makes it seem it's in seconds. But the recorded values are in nanoseconds.
Copy link

dosubot bot commented Dec 11, 2023

🤖

Thank you for bringing this to our attention! It's great to see your interest in improving the documentation for GoReplay. Your observations are valuable, and it would be fantastic if you could contribute to the project by creating a pull request with the updated and accurate information. Your efforts will help improve the overall user experience and understanding of GoReplay. If you have any questions or need assistance with the process of creating a pull request, feel free to ask. Your contribution will be greatly appreciated!


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

ThomasG77 referenced this issue in ThomasG77/goreplay Mar 19, 2024
ThomasG77 referenced this issue in ThomasG77/goreplay Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant