Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXC_BREAKPOINT crash when I call Bugfender.sessionIdentifierUrl() #48

Closed
nex-derek opened this issue Jul 31, 2019 · 7 comments
Closed

Comments

@nex-derek
Copy link

Hi, I'm using version 1.6.6 via Cocoapods. While I setup Bugfender in application:didFinishLaunchingWithOptions:, I hit this crash occasionally. Does anyone hit the same issue? Thanks.

64328308_411573416143205_9121278972011741184_n

@jgimenez
Copy link
Member

jgimenez commented Aug 1, 2019

Hi @nex-derek , I see the Bugfender.sessionIdentifierUrl() method actually returns a URL? instead of a URL as declared, we'll need to fix that.

The nil case can happen when Bugfender has not been activated yet (Bugfender.activateLogger() not called), which I don't think is the case here. It would be interesting to see the stacktrace to determine if the error is happening when calling absoluteString on a nil object, or rather is something happening inside sessionIdentifierUrl()

@nex-derek
Copy link
Author

Hey @jgimenez , thanks for speedy reply. I agree what you said and I believe that caused by something inside sessionIdentifierUrl(). Attached the stacktrace but I don't feel like there is any insight. I've tried to dispatch the call into the main thread and the crash seems disappear. Not sure if it helps your investigation. Thanks!

67384342_707556399673341_3481525151839813632_n
67896727_465466080698228_1419095265188511744_n

@jgimenez
Copy link
Member

jgimenez commented Aug 1, 2019

Thanks @nex-derek , this stacktrace confirms the function is returning nil, which shouldn't, because it's of type URL. Maybe the multi-threading thing is a good pointer, our engineers are looking into it

@nex-derek
Copy link
Author

Looking forward for the fix @jgimenez. Thanks!

@RubenVot
Copy link
Contributor

RubenVot commented Aug 7, 2019

Hi @nex-derek , we just finished the release of the 1.7.0 version in which we have changed how the session id is generated. Your code should work well after you upgrade.
In the new version you will have to unwrap the sessionIdentifier value. This was needed in the current architecture.
Thanks a lot for your feedback!

@RubenVot RubenVot closed this as completed Aug 7, 2019
@nex-derek
Copy link
Author

Thanks @RubenVot, may I know in what cases it will return nil?

@RubenVot
Copy link
Contributor

RubenVot commented Aug 7, 2019

That´s a good question @nex-derek .
In the new implementation, the identifiers are generated synchronously so the SDK should return null exclusively if you forget to call activateLogger before requesting the session id.
Let us know if you find any issue using the new version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants