-
-
Notifications
You must be signed in to change notification settings - Fork 24
Conversation
Hi, @js361014!
|
I've provided some information. |
Are you ready to review? |
Yes. |
Could you pay attention on my comments above? |
Maybe can we provide non-default projects for Smtp/Inspector/Ray in a separete PR? I think it could require from me to spend more time on getting deeper into Smtp/Inspector/Ray. I would prefer to focus now on sentry module. |
Ok, it's not a problem! Thank you for the PR, I really appreciate your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please, fix Code style
https://github.styleci.io/analyses/22ZbyZ?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
|
||
class FindAllProjects implements Query | ||
{ | ||
public function __construct() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove constructor
There is a problem with tests also. It would be great if you fix them. |
6636b63
to
157f530
Compare
Default project is assigned to events by default. For sentry events project id is taken from projectId param in sentry.event.store route. Events can by filtered by setting projectId in events.type route.
I've fixed code style and tests. |
Default project is assigned to events by default.
For sentry events project id is taken from
projectId param in sentry.event.store route.
Events can by filtered by setting projectId
in events.type route.