Skip to content
This repository has been archived by the owner on May 20, 2023. It is now read-only.

Add projects for events #92

Merged
merged 1 commit into from
Aug 1, 2022
Merged

Conversation

js361014
Copy link
Contributor

@js361014 js361014 commented Jul 29, 2022

Default project is assigned to events by default.
For sentry events project id is taken from
projectId param in sentry.event.store route.
Events can by filtered by setting projectId
in events.type route.

@butschster butschster self-assigned this Jul 30, 2022
@butschster butschster added enhancement New feature or request improvement Improvements or additions to code labels Jul 30, 2022
@butschster
Copy link
Member

Hi, @js361014!
Could you provide some information about using projects in the PR description.

  • How to use it with Ray
  • SMTP
  • Sentry
  • Var dumper
  • Inspector

@js361014
Copy link
Contributor Author

Hi, @js361014! Could you provide some information about using projects in the PR description.

* How to use it with Ray

* SMTP

* Sentry

* Var dumper

* Inspector

I've provided some information.

@butschster
Copy link
Member

I've provided some information.

Are you ready to review?

@js361014
Copy link
Contributor Author

I've provided some information.

Are you ready to review?

Yes.

@butschster
Copy link
Member

I've provided some information.

Are you ready to review?

Yes.

Could you pay attention on my comments above?

@js361014
Copy link
Contributor Author

js361014 commented Aug 1, 2022

Maybe can we provide non-default projects for Smtp/Inspector/Ray in a separete PR? I think it could require from me to spend more time on getting deeper into Smtp/Inspector/Ray. I would prefer to focus now on sentry module.

@butschster
Copy link
Member

Maybe can we provide non-default projects for Smtp/Inspector/Ray in a separete PR? I think it could require from me to spend more time on getting deeper into Smtp/Inspector/Ray. I would prefer to focus now on sentry module.

Ok, it's not a problem! Thank you for the PR, I really appreciate your contribution!

Copy link
Member

@butschster butschster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


class FindAllProjects implements Query
{
public function __construct()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove constructor

@butschster
Copy link
Member

There is a problem with tests also. It would be great if you fix them.

@butschster butschster added this to In progress in Server via automation Aug 1, 2022
@butschster butschster added this to the 2.0 milestone Aug 1, 2022
@js361014 js361014 force-pushed the projects branch 3 times, most recently from 6636b63 to 157f530 Compare August 1, 2022 17:36
Default project is assigned to events by default.
For sentry events project id is taken from
projectId param in sentry.event.store route.
Events can by filtered by setting projectId
in events.type route.
@js361014
Copy link
Contributor Author

js361014 commented Aug 1, 2022

I've fixed code style and tests.

@butschster butschster merged commit c9a82ae into buggregator:master Aug 1, 2022
Server automation moved this from In progress to Done Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants