Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Logger instead of :error_logger #120

Open
antedeguemon opened this issue Oct 20, 2022 · 1 comment
Open

Use Logger instead of :error_logger #120

antedeguemon opened this issue Oct 20, 2022 · 1 comment

Comments

@antedeguemon
Copy link

This library currently adds a hook to Erlang's :error_logger when the use_logger flag is enabled (at this line). But since Elixir 1.7, Logger is the preferred way of hooking into error logs (see Erlang/OTP logger integration section here).

As Elixir ~> 1.8 is already required by this library, I think it should move towards Logger hooking instead.

@antedeguemon
Copy link
Author

Ooops, there is already a pull request for that - #118.

I will leave the issue open while the PR isn't merged. Maintainers, please feel free to close this issue if it is not adequate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant