Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FatalErrorException gets sent twice #31

Closed
gregrobson opened this issue Nov 6, 2014 · 2 comments
Closed

FatalErrorException gets sent twice #31

gregrobson opened this issue Nov 6, 2014 · 2 comments

Comments

@gregrobson
Copy link
Contributor

I was just testing some changes I have made and I noticed that when a fatal syntax error occurs and a Symfony\Component\Debug\Exception\FatalErrorException is thrown Bugsnag is notified twice?

These errors wouldn't make it into our production code of course 😉 I just thought you might want to know in case that's something you need to be aware of.

@gregrobson
Copy link
Contributor Author

On further inspection (and some commenting out of lines) it appears to be in BugsnagLaravelServiceProvider.php

// Register for exception handling
$app->error(function (\Exception $exception) use ($app) {
    $app['bugsnag']->notifyException($exception);
});

// Register for fatal error handling
$app->fatal(function ($exception) use ($app) {
    $app['bugsnag']->notifyException($exception);
});

The FatalErrorExeception is being picked by error() and fatal().

@snmaynard
Copy link
Contributor

Closing as we have merged a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants