Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requires publishing configuration #92

Closed
bkuhl opened this issue Feb 8, 2016 · 5 comments
Closed

Requires publishing configuration #92

bkuhl opened this issue Feb 8, 2016 · 5 comments

Comments

@bkuhl
Copy link

bkuhl commented Feb 8, 2016

Currently this package requires that configuration be published. This is an annoying step and it would be ideal if we didn't have to publish the config and the package would read the environment variables out of the box.
@GrahamCampbell
Copy link
Contributor

Thanks for getting in touch. Sounds good to me. Are you able to send a PR please?

@bkuhl
Copy link
Author

bkuhl commented Jun 21, 2016

Looks like someone implemented that since this issue was created.

@bkuhl bkuhl closed this as completed Jun 21, 2016
@GrahamCampbell
Copy link
Contributor

Doesn't looks like it? https://github.com/bugsnag/bugsnag-laravel/blob/master/src/config/config.php

@bkuhl
Copy link
Author

bkuhl commented Jun 21, 2016

Ah... I looked at https://github.com/bugsnag/bugsnag-laravel#environment-variables. I'll submit a PR

@bkuhl bkuhl reopened this Jun 21, 2016
@GrahamCampbell
Copy link
Contributor

Thank you. 🍕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkuhl @GrahamCampbell