Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Throwable #101

Closed
GrahamCampbell opened this issue Dec 3, 2015 · 3 comments
Closed

Support Throwable #101

GrahamCampbell opened this issue Dec 3, 2015 · 3 comments

Comments

@GrahamCampbell
Copy link
Contributor

It would be good if notifyException would support Throwable.

@kattrali
Copy link
Contributor

This is a great idea, @GrahamCampbell. I'll be looking into making notifyException work well with PHP7, as well as some options for preserving backwards compatibility. Any suggestions are also welcome.

@cmstone
Copy link
Contributor

cmstone commented Dec 22, 2015

It seems that the only way to preserve the compatibility between 5.x and 7.x is to remove the parameter type declaration from the function definition. 7.x Errors and Exceptions implement Throwable interface which has the same methods as the 5.x Exception class.

Please look at cmstone/bugsnag-php@f312641

@kattrali
Copy link
Contributor

Thanks for the report, @GrahamCampbell. An updated version should be out later today with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants