Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter filtering is inconsistent with rails #137

Closed
tamird opened this issue Aug 3, 2014 · 0 comments · Fixed by #146
Closed

parameter filtering is inconsistent with rails #137

tamird opened this issue Aug 3, 2014 · 0 comments · Fixed by #146

Comments

@tamird
Copy link
Contributor

tamird commented Aug 3, 2014

We observe that bugsnag is filtering parameters with semantics completely different from those used by rails. For instance, our rails application is configured to filter out the parameter "q", which in rails is an exact match, while bugsnag filters all strings including the character "q" (think action_dispatch.request.*).

Here's the responsible line in the bugsnag railitie: https://github.com/bugsnag/bugsnag-ruby/blob/master/lib/bugsnag/railtie.rb#L2

And Rails' ParameterFilter: https://github.com/rails/rails/blob/master/actionpack/lib/action_dispatch/http/parameter_filter.rb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant