Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why not using NLog.ILogger #18

Open
LordPinhead opened this issue Jun 27, 2018 · 3 comments
Open

Question: Why not using NLog.ILogger #18

LordPinhead opened this issue Jun 27, 2018 · 3 comments

Comments

@LordPinhead
Copy link

Why did you create an extra Interface for the ILogger? I changed it to global::NLog.ILogger so i do not have to Strongname it in my Application. Is it why you commented "//TODO: UPDATE TO USE NLOG:INTERFACE Package (Fork and solve nlog.interface issues)" in the ILogger?

@davidshen84
Copy link

Or at least explicitly document that the ILogger interface should be the one from the Autofac.Extras.NLog namespace.

@304NotModified
Copy link

304NotModified commented Mar 23, 2019

@CNBoland

This is fixed by #19?

@CNBoland
Copy link
Collaborator

@304NotModified @davidshen84 @LordPinhead Can you verify in your project that injecting NLog.ILogger is working for you? The Sample.ConsoleApp project in source tree is configured this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants