Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfortune method to log exception #9

Open
rosieks opened this issue Nov 6, 2016 · 4 comments
Open

Unfortune method to log exception #9

rosieks opened this issue Nov 6, 2016 · 4 comments

Comments

@rosieks
Copy link

rosieks commented Nov 6, 2016

ILogger interface has unfortune method void Error([Localizable(false)] string message, Exception exception). It's fine when I pass Exception class, but when I pass any other exception C# compiler choose different method to use: void Error<TArgument>([Localizable(false)] string message, TArgument argument).

The effect is that exception details are not logged. I suggest to change order of parameters and deprecate original method.

@shoftee
Copy link
Contributor

shoftee commented Oct 12, 2017

I've opened #15 regarding this issue, but the author is not responding :<

@bugthesystem
Copy link
Owner

Hi @ALL sorry for late response, it is merged and will be pushed soon, @shoftee thanks for your contribution 👍

@304NotModified
Copy link

I think this could be closed with the release of 2.0.0-rc

@CNBoland
Copy link
Collaborator

@rosieks @shoftee @304NotModified Can you verify its working now in your projects with current versions of the NuGet packages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants