Skip to content

Commit

Permalink
Bug 1044561: Bad definition of indexes for the new user_api_keys DB t…
Browse files Browse the repository at this point in the history
…able

r=sgreen a=glob
  • Loading branch information
LpSolit committed Jul 31, 2014
1 parent 98041ff commit 8770b2c
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Bugzilla/DB/Schema.pm
Expand Up @@ -1749,8 +1749,8 @@ use constant ABSTRACT_SCHEMA => {
last_used => {TYPE => 'DATETIME'},
],
INDEXES => [
user_api_keys_key => {FIELDS => ['api_key'], TYPE => 'UNIQUE'},
user_api_keys_user_id => {FIELDS => ['user_id']},
user_api_keys_api_key_idx => {FIELDS => ['api_key'], TYPE => 'UNIQUE'},
user_api_keys_user_id_idx => ['user_id'],
],
},
};
Expand Down
17 changes: 17 additions & 0 deletions Bugzilla/Install/DB.pm
Expand Up @@ -723,6 +723,9 @@ sub update_table_definitions {
$dbh->bz_alter_column('tokens', 'tokentype',
{TYPE => 'varchar(16)', NOTNULL => 1});

# 2014-07-27 LpSolit@gmail.com - Bug 1044561
_fix_user_api_keys_indexes();

################################################################
# New --TABLE-- changes should go *** A B O V E *** this point #
################################################################
Expand Down Expand Up @@ -3881,6 +3884,20 @@ sub _fix_components_primary_key {
}
}

sub _fix_user_api_keys_indexes {
my $dbh = Bugzilla->dbh;

if ($dbh->bz_index_info('user_api_keys', 'user_api_keys_key')) {
$dbh->bz_drop_index('user_api_keys', 'user_api_keys_key');
$dbh->bz_add_index('user_api_keys', 'user_api_keys_api_key_idx',
{ FIELDS => ['api_key'], TYPE => 'UNIQUE' });
}
if ($dbh->bz_index_info('user_api_keys', 'user_api_keys_user_id')) {
$dbh->bz_drop_index('user_api_keys', 'user_api_keys_user_id');
$dbh->bz_add_index('user_api_keys', 'user_api_keys_user_id_idx', ['user_id']);
}
}

1;

__END__
Expand Down

0 comments on commit 8770b2c

Please sign in to comment.