Rename InitializeBuildParams to BuildInitializeParams (same for ShutdownBuildParams)

[agluszak]

Params of methods "build/initialize" and "build/shutdown" are named "InitializeBuildParams" and "ShutdownBuildParams", so to keep things consistent we should rename the params. All other params are named "${methodName}Params}".

BTW, I think we should remove the "build" part of it altogether, because these methods are not related in any way to building. They are related to the lifetime of the server.

[jastice]

Params of methods "build/initialize" and "build/shutdown" are named "InitializeBuildParams" and "ShutdownBuildParams", so to keep things consistent we should rename the params. All other params are named "${methodName}Params}".

Agree, let's keep naming consistent.

BTW, I think we should remove the "build" part of it altogether, because these methods are not related in any way to building. They are related to the lifetime of the server.

Not sure I agree. Naming is based on json-rpc method names. To change it we'd have to change the protocol. I think the rationale for this name is that build refers to the scope of the build server, not a build action. However, we could consider renaming them in a future protocol version - maybe server/initialize or just workspace/initialize? Depending on how they would be intended.

[agluszak]

To change it we'd have to change the protocol. I think the rationale for this name is that build refers to the scope of the build server, not a build action. However, we could consider renaming them in a future protocol version - maybe server/initialize or just workspace/initialize?

Agreed

[616b2f]

To change it we'd have to change the protocol. I think the rationale for this name is that build refers to the scope of the build server, not a build action. However, we could consider renaming them in a future protocol version - maybe server/initialize or just workspace/initialize?

With the introduction of Base Protocol, this still would make sense to do (but maybe in the next version of the protocol). See https://microsoft.github.io/language-server-protocol/specifications/base/0.9/specification/#initialize