Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In the Share a service window, the Name attribute should not have the /service/ prefix #5684

Closed
Tracked by #5683
adrianbenavides opened this issue Aug 21, 2023 · 0 comments
Closed
Tracked by #5683

In the Share a service window, the Name attribute should not have the /service/ prefix #5684

adrianbenavides opened this issue Aug 21, 2023 · 0 comments
Assignees
@etorreborre @adrianbenavides
Labels
Component: App good first issue help wanted Implementation: Typescript

Comments

@adrianbenavides
Copy link
Member

adrianbenavides commented Aug 21, 2023 •
edited
Loading

Current

In the Desktop app, when creating a new service (i.e. the "Share a service" window), the Name value contains a prefix that is constant, so it shouldn't be visible to the user.

image

Desired

The Name placeholder should just contain the service name without the /service/ prefix.

The app backend doesn't need to be updated, as it already sanitizes the service name value and accepts both /service/name and name formats.

We love helping new contributors!
If you have questions or need help as you work on your first Ockam contribution, please leave a comment on this discussion.
If you're looking for other issues to contribute to, checkout this discussion and labels - good first issue or help wanted

@adrianbenavides adrianbenavides mentioned this issue Aug 21, 2023
Closed
3 tasks
@adrianbenavides adrianbenavides changed the title The “Name” should not have “/service/” prefix, just “outlet” The "Name" should not have "/service/" prefix, just "outlet" Aug 21, 2023
@adrianbenavides adrianbenavides changed the title The "Name" should not have "/service/" prefix, just "outlet" In the Share a service window, the name attribute should not have the "/service/" prefix Aug 21, 2023
@adrianbenavides adrianbenavides changed the title In the Share a service window, the name attribute should not have the "/service/" prefix In the Share a service window, the Name attribute should not have the "/service/" prefix Aug 21, 2023
@adrianbenavides adrianbenavides changed the title In the Share a service window, the Name attribute should not have the "/service/" prefix In the Share a service window, the Name attribute should not have the /service/ prefix Aug 21, 2023
@etorreborre etorreborre self-assigned this Aug 25, 2023
@etorreborre etorreborre mentioned this issue Aug 31, 2023
Merged
@adrianbenavides adrianbenavides self-assigned this Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@etorreborre etorreborre

@adrianbenavides adrianbenavides

Labels
Component: App good first issue help wanted Implementation: Typescript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etorreborre @adrianbenavides