Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ockam tcp-inlet delete --help text (clap command) #6645

Closed
nazmulidris opened this issue Oct 18, 2023 · 3 comments · Fixed by #6661
Closed

Improve ockam tcp-inlet delete --help text (clap command) #6645

nazmulidris opened this issue Oct 18, 2023 · 3 comments · Fixed by #6661
Assignees
@Michaelin007
Labels
Component: Command good first issue hacktoberfest Apply to issues you want contributors to help with help wanted Implementation: Rust Type: User Experience

Comments

@nazmulidris
Copy link
Contributor

Current behavior

When a user runs ockam tcp-inlet delete --help then the following output is displayed.

Image

Desired behavior

Change the help text for the <ALIAS> argument to say: Delete the inlet with this alias name

Implementation details

Change the Rust doc comment for the DeleteCommand::alias field in this file

We love helping new contributors! ❤️
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.
@Michaelin007
Copy link
Contributor

Michaelin007 commented Oct 18, 2023 •
edited

can I work on this?

@Michaelin007
Copy link
Contributor

I created a PR for this already. You can review

@ashutosh-rath02
Copy link
Contributor

@Michaelin007 It will be great if you mention the issue in the PR.

@adrianbenavides adrianbenavides mentioned this issue Oct 19, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michaelin007 Michaelin007

Labels
Component: Command good first issue hacktoberfest Apply to issues you want contributors to help with help wanted Implementation: Rust Type: User Experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve ockam tcp-inlet delete --help text (clap command) Michaelin007/ockam
3 participants
@nazmulidris @Michaelin007 @ashutosh-rath02