Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make install.sh not fail during upgrade process #7118

Open
snandam opened this issue Dec 12, 2023 · 1 comment
Open

Make install.sh not fail during upgrade process #7118

snandam opened this issue Dec 12, 2023 · 1 comment

Comments

@snandam
Copy link
Member

snandam commented Dec 12, 2023

Current behavior

Script runs without any error when Installation script is run first time on a machine

In the case of rerunning the script when there are running ockam processes, script errors out

   INFO Installing Ockam Command ...
   INFO Detecting Operating System and Architecture ...
   INFO Detected Operating System Type: Linux
   INFO Detected CPU Type: x86_64
   INFO Picked Released File Name: ockam.x86_64-unknown-linux-musl
   INFO Creating binary directory at specified install path
   INFO Binary directory successfully created
   INFO Installing latest version
   INFO Downloading https://github.com/build-trust/ockam/releases/latest/download/ockam.x86_64-unknown-linux-musl
curl: (23) Failure writing output to destination

Steps to reproduce

Tested on Ubuntu and CentOS

  • Download https://github.com/build-trust/ockam/blob/develop/tools/install.sh
  • Update permission chmod +x install.sh
  • Run installation ./install.sh
  • Wait for a successful install
  • Create a node ockam node create
  • Run installation ./install.sh again (Fails)
  • Find pid for the running process ps aux | grep [o]ckam and kill using kill -9 {PID}
  • Run installation ./install.sh again (Succeeds)

Desired behavior

  • Ensure that the script gracefully handles situations when there are running ockam processes
  • Kill the existing running processes safely asking users permission to kill the process.
  • Update error messages and handling to better reflect what's happening in those situation

Ockam Version

v0.108.0

@snandam snandam changed the title Make install.sh idempotent Make install.sh not fail when the latest version is already installed Dec 13, 2023
@snandam snandam changed the title Make install.sh not fail when the latest version is already installed Make install.sh not fail during upgrade process Dec 13, 2023
@smoofy24
Copy link

smoofy24 commented May 8, 2024

I can try to help with this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants