New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added template for retrieving Sellix blacklists #41
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, I've added a few comments!
"SELLIX_API_BASE": "" | ||
}, | ||
"fee": 0, | ||
"image": "https://cdn.sellix.io/static/logo/sellix-logo-black-smaller.png", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned in the previous review, the logo URL should be:
https://assets.buildable.dev/catalog/node-templates/sellix.svg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops! I thought I'd done this, must've forgot. Fixed in the latest commit.
@paulkr , I fixed that last set of issues a while back. Could I have further feedback on this? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @flancast90, the structure of the repo and the input/run files has been updated since the migration to Buildable V3. You can refer to the contribution guidelines for action templates found here: https://github.com/buildable/connections/blob/main/actions/docs/CONTRIBUTING.md
Closing as the PR needs to be redone for the updated version of Buildable. |
Hey @paulkr ,
I've added a template for the Sellix API's GET blacklist for specified user. Let me know if there's anything you need changed, or anything you have questions about. I've tested in a flow already, and can verify it works as expected.
Thanks!