Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added template for retrieving Sellix blacklists #41

Closed
wants to merge 3 commits into from
Closed

Added template for retrieving Sellix blacklists #41

wants to merge 3 commits into from

Conversation

flancast90
Copy link

Hey @paulkr ,

I've added a template for the Sellix API's GET blacklist for specified user. Let me know if there's anything you need changed, or anything you have questions about. I've tested in a flow already, and can verify it works as expected.

Thanks!

Copy link
Member

@paulkr paulkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, I've added a few comments!

templates/sellix/get-blacklist/config.json Outdated Show resolved Hide resolved
templates/sellix/get-blacklist/config.json Outdated Show resolved Hide resolved
templates/sellix/get-blacklist/config.json Outdated Show resolved Hide resolved
templates/sellix/get-blacklist/input.js Outdated Show resolved Hide resolved
@flancast90
Copy link
Author

@paulkr , I've added the changes you mentioned, as well as opened #42 about accepting default env values for better future readability.

@paulkr paulkr self-requested a review June 3, 2022 16:50
templates/sellix/get-blacklist/config.json Show resolved Hide resolved
"SELLIX_API_BASE": ""
},
"fee": 0,
"image": "https://cdn.sellix.io/static/logo/sellix-logo-black-smaller.png",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in the previous review, the logo URL should be:

https://assets.buildable.dev/catalog/node-templates/sellix.svg

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! I thought I'd done this, must've forgot. Fixed in the latest commit.

@flancast90
Copy link
Author

@paulkr , I fixed that last set of issues a while back. Could I have further feedback on this? Thanks!

Copy link
Member

@paulkr paulkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @flancast90, the structure of the repo and the input/run files has been updated since the migration to Buildable V3. You can refer to the contribution guidelines for action templates found here: https://github.com/buildable/connections/blob/main/actions/docs/CONTRIBUTING.md

@paulkr
Copy link
Member

paulkr commented Aug 30, 2022

Closing as the PR needs to be redone for the updated version of Buildable.

@paulkr paulkr closed this Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants