Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what does LTTM mean? #117

Closed
skydivedan opened this issue Aug 25, 2015 · 3 comments
Closed

what does LTTM mean? #117

skydivedan opened this issue Aug 25, 2015 · 3 comments

Comments

@skydivedan
Copy link

Sorry for the silly question, but I can't figure this acronym.

At work, we use "LGTM" for "Looks good to me", when approving a pull request. So, I assume it's something close, but I can't figure out what that first "T" is.

@czechboy0
Copy link
Member

Good question, I actually don't have it spelled out in the readme. It means "looks testable to me" and the rationale is described here. Basically, our tests take about 20mins, so we want to make sure the human reviewer is happy with the code before it gets tested.

@czechboy0
Copy link
Member

And yes, we derived it from "lgtm".

@skydivedan
Copy link
Author

ok, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants