Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch's commit statuses based on a non-PR bot #18

Closed
7 tasks done
czechboy0 opened this issue May 3, 2015 · 2 comments · Fixed by #61
Closed
7 tasks done

Update branch's commit statuses based on a non-PR bot #18

czechboy0 opened this issue May 3, 2015 · 2 comments · Fixed by #61
Assignees

Comments

@czechboy0
Copy link
Member

Think about how we could also add a syncer for not just PRs, but only for a "monitored" branch, e.g. master. A way to monitor a branch with a bot and to update the commit's status based on the bot's result. Would require a slight refactor where we'd allow the syncer to instead of resolving (PR + Bot) pairs to (branch + Bot) pairs, where PRs would just be one source of the monitored branch and we might have the user manually specify another, non-PR'ed branch to also be monitored and updated on GitHub.

  • Split the main syncer into multiple classes
  • Migrate to a SyncPair process, where each pair (Bot + PR, No Bot + PR, Bot + No PR) has its own class that handles its actions. Will scale better for new syncable pairs (Bot + Branch, ...)
  • Add tests for the right SyncPair creation based on inputs from GitHub and XCS
  • Introduce a Bot + Branch Sync Pair, which will share a lot with Bot + PR, share as much as possible
  • Add a way in the UI to mark particular branches to be synced permanently (no need for a PR)
  • Answer the question: will we allow picking a different Build Template for synced branches?
  • Enable this on master here in Buildasaur and test that it works well for a couple of days
@czechboy0
Copy link
Member Author

Work started.

@czechboy0
Copy link
Member Author

At the moment, we use the PR's Build Template. If this is a problem and you'd like to pick a different template for different branches, create an issue with the description of your usecase and I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant