Fix timed schedulers #1325
Merged
Fix timed schedulers #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, sourcestamp['codebase'] is a string, not a dict.
Remove the firstBuildDuration parameter, it's not used anywhere. Make use of the faked addBuildsetForSourceStampWithDefaults method, so that the tests may use that instead of the hand-rolled events list. Also, refactor some tests.
Also sched.activate() might become async. Adjust tests accordingly.
Also, remove 3 tests from test_schedulers_basic. The desired functionality is implemented and tested in the mixin.
This can be used by the startBuild implementations. If the scheduler has collected and classified any changes, it will use `addBuildsetForChanges` and flush the change classifications. If there are no changes it will use `addBuildsetForSourceStampsWithDefaults`. If `onlyIfChanged` was given and there are no important changes, the method will return without triggering any builds. Collected changes won't be flushed from the database.
The method is called addBuildsetForSourceStamps (plural) not addBuildsetForSourceStamp.
- don't filter on codebase as dustin suggested - add a parameter change_filter
Closed
|
👍 Thanks & sorry I can't find the time :/ |
|
@jpommerening no worries - that's what OSS is for :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR continues the work of the PR #1192.
Eg: it implements dustin's comment: #1192 (comment)