Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyError in github_buildbot.py on commits by non-Github users #2931

Closed
tardyp opened this issue Mar 9, 2017 · 1 comment
Closed

KeyError in github_buildbot.py on commits by non-Github users #2931

tardyp opened this issue Mar 9, 2017 · 1 comment
Milestone

Comments

@tardyp
Copy link
Member

tardyp commented Mar 9, 2017

This ticket is a migrated Trac ticket 3228

People contributed to the original ticket: buildbot.net@..., @djmitche
Ticket created on: Mar 12 2015
Ticket last modified on: Mar 17 2015


When a commit by an user not known to github (e.g. [[this|https://github.com/The-Compiler/qutebrowser/commit/4fa64350ca26a79569a000312740c57adc660e90]]) is pushed, github_buildbot.py has a [[KeyError]] when trying to get the username of the change:

Traceback (most recent call last):
File "/usr/local/bin/github_buildbot.py", line 138, in render_POST
self.process_change(payload, user, repo, repo_url, project, request)
File "/usr/local/bin/github_buildbot.py", line 166, in process_change
change[[change['author']['email'|'author']['username'],]])
[[KeyError]]: 'username'

@tardyp tardyp added this to the 0.9.+ milestone Mar 9, 2017
@seankelly
Copy link
Member

This is in contrib, but was fixed in #1801.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants