-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix value of test requiring integer to use integer #126
Comments
This has been discussed here: #89 I think the sentiment there was that (requiring) a 3rd state (fail, pass, invalid IDS) would result in the most additional effort. So requiring failure on this rule is the quickest way towards consistent behaviour among all tools. Validation of the IDS itself can be a later step and is a potentially rather nuanced. |
Now we have the third state, given the effort put in the auditing of IDSs. |
Maybe, the more relevant point to discuss is this file, which passes: |
Regardless from the decision we take on third state we need to include https://github.com/buildingSMART/IDS/blob/master/Documentation/testcases/property/pass-integer_values_are_checked_using_type_casting_3_4.ids when considering what is a valid value for IDS |
I'd support these states: fail, pass, and an optional 'invalid IDS' (as specialisation of fail). |
This file requires measure to be IfcInteger and simpleValue is a decimal number. I think we should consider this kind of IDS fail illegal. It makes no sense to put extra effort to the implementations to cover for these kind of cases.
The text was updated successfully, but these errors were encountered: