You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In regard to the 0.9.6 release I would like to make some comments regarding findings in the test-cases, specifically for tests concerning the Attribute- and Classification-Facet.
1) Attribute-Facet Test-Case:
fail - a prohibited facet returns the opposite of a required facet
This test-case lost its meaning, since the attribute-facet no longer contains min- and maxOccurs to represent the prohibited constraint.
2) Attribute-Facet Test-Case:
pass - an optional facet always passes regardless of outcome 2 2
This test-case lost its meaning, since the attribute-facet no longer contains min- and maxOccurs to represent the optional constraint.
There are certainly more cases for the attribute-facet that has to be reviewed based on the now missing min- and maxOccurs. The here listed cases are certain to now be broken.
3) Classification-Facet Test-Case:
pass - Occurrences override the type classification per system 1/3
pass - Occurrences override the type classification per system 3/3
The IFC for both classification tests are containing exactly two IFCWALL entities. One is compliant with the IDS, the other is not. This results in a failed check for the specification, not meeting the pass requirement of the test-case. To fix this, I would simply rename the following entity to fix the test-cases:
#4=IFCWALL... -> #4=IFCSLAB...
If not renaming the failing wall entity, it has to have a valid classification to resolve successful.
4) Classification-Facet Test-Case:
pass - Values match subreferences if full classifications are used (e.g. EF_25_10 should match EF_25_10_25, EF_25_10_30, etc)
This test-case tries to utilize a simpleValue constraint as if it is a regular expression. A simpleValue should remain a check for equivalence. To create a check that allows creating a "starts with" constraint, such as for EF_25_10 resolving successfull for EF_25_10_25 and EF_25_10_30, a RegEx pattern can be formulated and should be used instead, like this:
I addition to that, the simple check for 2 or 22 as classification value does not comply with the description of the test-case.
5) All Test-Case:
It has to be noted, that all test cases currently use min- and maxOccurs with the values [1, 1]. In the documentation it is explicitly stated, that only combinations resulting in prohibited, optional and required are allowed. So, the combination [1, 1] for min- and maxOccurs is invalid!
The text was updated successfully, but these errors were encountered:
I believe this is a correct test. It's checking that '2' matches a classification in the ancestry. The IfcBeam is classified to '22' which has a parent classification of '2'. Some of these Classification tests are a bit "noisy" I found, so it takes some working out the intent
In regard to the 0.9.6 release I would like to make some comments regarding findings in the test-cases, specifically for tests concerning the Attribute- and Classification-Facet.
1) Attribute-Facet Test-Case:
This test-case lost its meaning, since the attribute-facet no longer contains min- and maxOccurs to represent the prohibited constraint.
2) Attribute-Facet Test-Case:
This test-case lost its meaning, since the attribute-facet no longer contains min- and maxOccurs to represent the optional constraint.
There are certainly more cases for the attribute-facet that has to be reviewed based on the now missing min- and maxOccurs. The here listed cases are certain to now be broken.
3) Classification-Facet Test-Case:
The IFC for both classification tests are containing exactly two IFCWALL entities. One is compliant with the IDS, the other is not. This results in a failed check for the specification, not meeting the pass requirement of the test-case. To fix this, I would simply rename the following entity to fix the test-cases:
If not renaming the failing wall entity, it has to have a valid classification to resolve successful.
4) Classification-Facet Test-Case:
This test-case tries to utilize a simpleValue constraint as if it is a regular expression. A simpleValue should remain a check for equivalence. To create a check that allows creating a "starts with" constraint, such as for EF_25_10 resolving successfull for EF_25_10_25 and EF_25_10_30, a RegEx pattern can be formulated and should be used instead, like this:
I addition to that, the simple check for 2 or 22 as classification value does not comply with the description of the test-case.
5) All Test-Case:
It has to be noted, that all test cases currently use min- and maxOccurs with the values [1, 1]. In the documentation it is explicitly stated, that only combinations resulting in prohibited, optional and required are allowed. So, the combination [1, 1] for min- and maxOccurs is invalid!
The text was updated successfully, but these errors were encountered: