Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to mark Reference property as deprecated where it duplicates the purpose of a construction type name #26

Closed
Moult opened this issue Jun 17, 2021 · 3 comments
Labels
allocated-core implemented Issue closed: Proposal implemented

Comments

@Moult
Copy link
Collaborator

Moult commented Jun 17, 2021

Full discussion here.

In short, architecture defines codes for construction types, such as D01 for a fire-rated, single leaf, metal framed door, and D02 for a non-fire rated, timber framed door.

The IFC documentation does not make it clear that these codes should be stored in the IfcTypeObject's Name attribute, even though that is the intention as mentioned by @TLiebich.

Also, there is a legacy Reference property when vendors didn't have support for types. But in 2021, most vendors do have type support. There is already an implementer agreement about this conflict, but let's resolve it and include in the docs.

I propose to remove this legacy Reference property so there is no more confusion, also I propose that on the IfcDoorType, IfcWallType, and IfcWindowType pages, a sentence be added basically giving an example of D01 like I gave above. More relatable examples I think will help ensure IFC data is more useful. The majority of export mappings currently get this wrong, and I see all sorts of stuff populated in the Name fields.

Ping @berlotti @TLiebich @aothms

@Moult Moult added allocated Step 1: Review teams should investigate this issue allocated-core labels Jun 17, 2021
@Moult
Copy link
Collaborator Author

Moult commented Feb 14, 2022

Note that this issue is related to #178. If this proposal were accepted, it would make it one location less confusing :)

@Moult Moult added proposal Step 2: A well defined proposal has been put forward and removed allocated Step 1: Review teams should investigate this issue labels Feb 14, 2022
@Moult
Copy link
Collaborator Author

Moult commented Feb 14, 2022

Voted

Keep:
Dunno: @aothms
Remove: @TLiebich @Moult

Result: remove :)

@Moult Moult added decided Step 3: The proposal has been approved and removed proposal Step 2: A well defined proposal has been put forward labels Feb 14, 2022
@aothms
Copy link
Collaborator

aothms commented Feb 20, 2022

As it stands this doesn't seem to affect UML.

@Moult Moult closed this as completed in 406ca0c Feb 22, 2022
@Moult Moult added implemented Issue closed: Proposal implemented and removed decided Step 3: The proposal has been approved labels Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
allocated-core implemented Issue closed: Proposal implemented
Projects
None yet
Development

No branches or pull requests

2 participants