Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate spacing values to particles #16

Open
james-nash opened this issue May 30, 2019 · 0 comments
Open

Migrate spacing values to particles #16

james-nash opened this issue May 30, 2019 · 0 comments
Assignees
Labels
design tokens CATEGORY: Anything related to creation or maintenance of Gravity's design tokens help wanted INVITATION: Indicates that a maintainer wants help on an issue or pull request 🌟 enhancement TYPE: Indicates new feature requests

Comments

@james-nash
Copy link

Is your feature request related to a problem? Please describe.
Currently, the SASS code in @buildit/gravity-ui-web defines a number of spacing values that are used throughout the UI (the $grav-sp-*) values.

They should be moved from there into this repo as design tokens. That way, we can begin to export and publish them into other formats to support platforms beyond just the web.

Describe the solution you'd like

  • Add new spacing design tokens in this repo
  • Update the StyleDictionary config and scripts to export them as suitable SASS vars & TS vars (and anything else we migth support)
  • Update the gravity-ui-web repo to:
    • Depend on the new version of @buildit/gravity-particles that contains the spacing values
    • Update the SASS code so that it no longer contains any $grav-sp-* variable declarations and instead imports those vars from @buildit/gravity-particles.
@james-nash james-nash added 🌟 enhancement TYPE: Indicates new feature requests design tokens CATEGORY: Anything related to creation or maintenance of Gravity's design tokens help wanted INVITATION: Indicates that a maintainer wants help on an issue or pull request labels May 30, 2019
@allancorbett allancorbett self-assigned this Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design tokens CATEGORY: Anything related to creation or maintenance of Gravity's design tokens help wanted INVITATION: Indicates that a maintainer wants help on an issue or pull request 🌟 enhancement TYPE: Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

2 participants