Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-login plugin does not logout #71

Closed
fiedlerdemos opened this issue Nov 28, 2023 · 1 comment · Fixed by #73
Closed

docker-login plugin does not logout #71

fiedlerdemos opened this issue Nov 28, 2023 · 1 comment · Fixed by #73
Assignees
Labels

Comments

@fiedlerdemos
Copy link

In my pipeline.yml I used:
- docker-login#v2.1.0:
username: xxxx
password-env: MY_DOCKER_LOGIN_PASSWORD
Every thing ok.
But after termination of pipeline in /var/lib/buildkite-agent/.docker/config.json remains with authentication information and not empty as it would be after appropriate logout.
So everyone using this agent can manipulate docker repos.

@toote
Copy link
Contributor

toote commented Nov 29, 2023

@fiedlerdemos that is actually a great find and points to a deeper issue when an instance has several agents as well. I will see what can be done about it

@toote toote added the bug label Nov 29, 2023
@toote toote self-assigned this Nov 29, 2023
@toote toote mentioned this issue Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants