Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unhandled rejection after choosing to open new issue in browser #2

Open
mnahkies opened this issue Feb 12, 2018 · 4 comments
Open

Unhandled rejection after choosing to open new issue in browser #2

mnahkies opened this issue Feb 12, 2018 · 4 comments
Labels

Comments

@mnahkies
Copy link

mnahkies commented Feb 12, 2018

Migrated an issue from sinonjs/sinon to sinonjs/nise. Received the following output, and an unhandled rejection.

Despite this message the issue was migrated, although I noticed that the ordering of the migrated comments was off (not a big deal as mostly they were irrelevant to the migrated issue so I deleted most of them).

Original Issue: sinonjs/sinon#607
Migrated Issue: sinonjs/nise#33

? You're about to migrate issue #607 from sinonjs/sinon to sinonjs/nise . Are you sure? Yes
😱 Something went wrong while migrating issue #607!
{
  "status": 403,
  "json": {
    "message": "Must have admin rights to Repository.",
    "documentation_url": "https://developer.github.com/v3/issues/#edit-an-issue"
  }
}
? Open new issue in browser now? Yes
(node:31573) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'htmlUrl' of undefined
(node:31573) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

Environment:
OS: Ubuntu 16.04 LTS
NodeJS: v8.9.4
NPM: v5.6.0

@gabro
Copy link
Member

gabro commented Feb 12, 2018

Thanks for the report @mnahkies, I'll try to take a look soon!

@gabro gabro added the bug label Feb 12, 2018
@gabro
Copy link
Member

gabro commented Feb 12, 2018

Does the error message resonate, by the way? Did the token you provided had admin right on the target repo?

@mnahkies
Copy link
Author

@gabro yes that error message is correct, I've contributed to that repository but am not an admin. Thanks, overall the tool did what it said on the tin, so thanks for that!

@gabro
Copy link
Member

gabro commented Feb 12, 2018

🎉 glad it was useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants