New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #32 #33
Fixes #32 #33
Conversation
@@ -4,6 +4,9 @@ Change History | |||
1.6.4 (unreleased) | |||
================== | |||
|
|||
- Make zc.buildout work behind a cntlm proxy | |||
[ale-rt] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be a good idea to link to the bug (https://bugs.launchpad.net/zc.buildout/+bug/484735).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment to the original report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant specifically in the changelog. When people go to pypi.python.org and try to see what changed in version X.Y.Z, it's very nice to have a clickable URL where you can read more about the bug (why it happens, how it's fixed, does it affect me? etc.).
We need tests as we support too many platforms to assert this without testing. |
You are absolutely right, @iElectric! Will try to provide them as soon as I can, but for the moment I don't have any clue about how to make good ones. |
Actually, this is already tested by travis-ci. Testing the actual proxy is hard work with current test setup. Now if only travis actually tested this PR. |
#32