Use escaped id when creating buildpack tar file #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkutner
force-pushed
the
fix-tmp-dir-name
branch
from
453e750
to
922a0e5
Compare
jkutner
force-pushed
the
fix-tmp-dir-name
branch
from
922a0e5
to
876c507
Compare
jkutner
force-pushed
the
fix-tmp-dir-name
branch
from
876c507
to
86344cf
Compare
ekcasey
approved these changes
Mar 25, 2019
There was a problem hiding this comment.
This looks good. Thanks for the fix. I am happy to merge once the conflicts are resolved.
I agree that we should probably escape versions. However, I believe that would require lifecycle changes first. The buildpack directory names shouldn't be "user facing" but currently the the BuildpackMap used for detection in lifecycle assumes that the version directory will match the version provided in group. We should change that to use the version in buildpack.toml instead of the directory name.
https://github.com/buildpack/lifecycle/blob/7c4df24760f6778e2cfa9bc862a72a4d2b372019/map.go#L30-L35
jkutner
force-pushed
the
fix-tmp-dir-name
branch
2 times, most recently
from
056de37
to
6654079
Compare
Signed-off-by: Joe Kutner <jpkutner@gmail.com>
jkutner
force-pushed
the
fix-tmp-dir-name
branch
from
6654079
to
2c84e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the case when the buildpack ID contains a
/, which is allowed.I'm also unsure if using the raw
versionstring is acceptable. We should probably hash the whole buildpack name/id/version since this is never user facing.