Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC #0105] Exporter changes for run image extension (Dockerfiles phase 3) #999

Closed
Tracked by #224
natalieparellano opened this issue Feb 2, 2023 · 0 comments · Fixed by #1055
Closed
Tracked by #224
Assignees
Labels
status/ready type/enhancement New feature or request

Comments

@natalieparellano
Copy link
Member

natalieparellano commented Feb 2, 2023

Spec PR: https://github.com/buildpacks/spec/pull/347/files

For newer platform API (0.12 and above), the exporter accepts -run instead of -stack and a new -extended flag. -extended is the location of the directory with extended run image layers. -run is the location of a run.toml file with schema:

[[image]]
 image = "<image>"
 mirrors = ["<mirror1>", "<mirror2>"]

When constructing the app image:

    - **If** image extensions were used to extend the `run-image` in [`analyzed.toml`](#analyzedtoml-toml):
      - MUST be based on the image in `<extended>`
    - **Else**:
      - MUST be based on the `run-image` in [`analyzed.toml`](#analyzedtoml-toml)

When finding run image mirrors, the exporter should use the appropriate value in run.toml.

The io.buildpacks.lifecycle.metadata label should be serialized according to the new schema defined in the spec PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant