Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't restore launch metadata when --clear-cache #101

Closed
sclevine opened this issue Feb 26, 2019 · 2 comments
Closed

Don't restore launch metadata when --clear-cache #101

sclevine opened this issue Feb 26, 2019 · 2 comments
Labels
good first issue A good first issue to get started with.
Milestone
0.1.0

Comments

@sclevine
Copy link
Member

No description provided.

@sclevine sclevine added this to Icebox in Planning Board via automation Feb 26, 2019
@ekcasey
Copy link
Member

ekcasey commented Mar 14, 2019

Motivation:

Right now --clear-cache prevents cached layers from being restored. However metadata from the previous image is still provided by the analyzer. This metadata can affect the behavior of the buildpack and result in layers from previous builds being reused rather than rebuilt. Users want to use --clear-cache to achieve a truly clean state. Therefore builds run with --clear-cache should skip the analyzer step.

Acceptance Criteria:

Given I have already built a given image tag once
When I run pack build with the --clear-cache flag
Then in addition to deleting any existing cache image, pack skips the restorer and analyzer lifecycle phases

@ekcasey ekcasey added the good first issue A good first issue to get started with. label Mar 14, 2019
@ekcasey ekcasey moved this from Icebox to Backlog in Planning Board Mar 14, 2019
@jromero jromero mentioned this issue Apr 1, 2019
Merged
@ekcasey ekcasey moved this from Backlog to Done in Planning Board Apr 1, 2019
@mgibson1121
Copy link
Member

This story passes acceptance

@mgibson1121 mgibson1121 moved this from Done to Release v0.1.0 in Planning Board Apr 2, 2019
@jromero jromero added this to the 0.1.0 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good first issue to get started with.
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
4 participants
@jromero @sclevine @ekcasey @mgibson1121