Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: Support build.pre.buildpacks build.post.buildpacks in project.toml #1100

Closed
jromero opened this issue Mar 5, 2021 · 2 comments
Closed

RFC: Support build.pre.buildpacks build.post.buildpacks in project.toml #1100

jromero opened this issue Mar 5, 2021 · 2 comments
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.

Comments

@jromero
Copy link
Member

jromero commented Mar 5, 2021

Description

Based on the RFC, we will want to support the additional properties in project.toml:

[build.pre]

  [[build.pre.buildpacks]]
  id = "<buildpack ID>"
  version = "<string>"
  uri = "<string>"

[build.post]

  [[build.post.buildpacks]]
  id = "<buildpack ID>"
  version = "<string>"
  uri = "<string>"

Proposed solution

See RFC "How it works".

Describe alternatives you've considered

Additional context
@jromero jromero added type/enhancement Issue that requests a new feature or improvement. status/blocked Issue or PR that is blocked. See comments. labels Mar 5, 2021
@jromero jromero mentioned this issue Mar 5, 2021
Open
4 tasks
@natalieparellano natalieparellano mentioned this issue Aug 18, 2023
Open
6 tasks
@jjbustamante jjbustamante added status/ready Issue ready to be worked on. and removed status/blocked Issue or PR that is blocked. See comments. labels Aug 18, 2023
@jjbustamante
Copy link
Member

This issue probably requires a small effort because this PR from Joe already added support on flags, we just need to add it into the project.toml

@jjbustamante jjbustamante added the good first issue A good first issue to get started with. label Aug 18, 2023
@natalieparellano natalieparellano added the help wanted Need some extra hands to get this done. label Aug 18, 2023
@natalieparellano
Copy link
Member

Actually looking at https://github.com/buildpacks/pack/pull/1621/files#diff-03220a2f3a516ece374582fcc687eb7c47a3c6e2dcd11e0f5a117c5a9c0decc6R1276 more closely, it appears this is already implemented. I'm going to close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good first issue to get started with. help wanted Need some extra hands to get this done. status/ready Issue ready to be worked on. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jromero @jjbustamante @natalieparellano