Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New flatten buildpacks/builder implementation - Part 1 - removing depth #1925

Merged
merged 14 commits into from
Dec 20, 2023

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Oct 3, 2023

Summary

This PR removes the --depth flag from pack builder create and pack buildpack package commands, because it is not being used.

Output

Before

pack builder create and pack buildpack package commands have the following flag:

Flags:
      --depth int    Max depth to flatten each composite buildpack.

After

The flag is not available.

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1880

@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Oct 3, 2023
@github-actions github-actions bot added this to the 0.32.0 milestone Oct 3, 2023
@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Oct 17, 2023
@jjbustamante jjbustamante modified the milestones: 0.33.0, 0.32.0 Oct 31, 2023
@jjbustamante jjbustamante added flatten feature experimental Issue or PR refers to an experimental feature. labels Nov 7, 2023
@github-actions github-actions bot modified the milestones: 0.33.0, 0.32.0 Nov 7, 2023
@jjbustamante jjbustamante modified the milestones: 0.32.0, 0.33.0 Nov 7, 2023
Removing --depth flag

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante force-pushed the enhancement/jjbustamante/flatten-1880/part-1 branch from 398c8cd to 068d130 Compare November 17, 2023 17:58
@jjbustamante jjbustamante marked this pull request as ready for review November 22, 2023 20:24
@jjbustamante jjbustamante requested review from a team as code owners November 22, 2023 20:24
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7b5164c) 79.64% compared to head (14684c7) 79.51%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
- Coverage   79.64%   79.51%   -0.12%     
==========================================
  Files         174      174              
  Lines       13126    13074      -52     
==========================================
- Hits        10453    10395      -58     
- Misses       2010     2016       +6     
  Partials      663      663              
Flag Coverage Δ
os_linux 78.43% <96.56%> (-0.10%) ⬇️
os_macos 76.22% <96.56%> (-0.11%) ⬇️
os_windows 78.90% <96.56%> (-0.12%) ⬇️
unit 79.51% <96.56%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Dec 11, 2023
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@github-actions github-actions bot removed the type/chore Issue that requests non-user facing changes. label Dec 11, 2023
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @jjbustamante. I added one question to understand it better. It's nice to see all the complexity going away here. My apologies for being the person to suggest 'depth' in the first place.

pkg/client/package_buildpack.go Outdated Show resolved Hide resolved
pkg/buildpack/builder.go Outdated Show resolved Hide resolved
pkg/buildpack/builder.go Outdated Show resolved Hide resolved
pkg/buildpack/managed_collection.go Outdated Show resolved Hide resolved
@jjbustamante
Copy link
Member Author

@natalieparellano thanks for you feedback! I will take a look

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante merged commit 18cdd3d into main Dec 20, 2023
18 checks passed
@jjbustamante jjbustamante deleted the enhancement/jjbustamante/flatten-1880/part-1 branch December 20, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Issue or PR refers to an experimental feature. flatten feature type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatten Feature
2 participants