Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the progress log when downloading files on windows #2006

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Dec 13, 2023

Summary

We added a retry to logic to workaround the error when downloading some files.

Output

Before

Acceptance tests on windows (LCOW) were failing

After

Acceptance test are passing

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #2005

@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Dec 13, 2023
@github-actions github-actions bot added this to the 0.33.0 milestone Dec 13, 2023
@github-actions github-actions bot added the type/chore Issue that requests non-user facing changes. label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e5d4417) 80.44% compared to head (9c64aff) 80.45%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
+ Coverage   80.44%   80.45%   +0.01%     
==========================================
  Files         172      172              
  Lines       12922    12926       +4     
==========================================
+ Hits        10394    10398       +4     
  Misses       1874     1874              
  Partials      654      654              
Flag Coverage Δ
os_linux 79.29% <100.00%> (+0.01%) ⬆️
os_macos 77.09% <100.00%> (+0.01%) ⬆️
os_windows 79.84% <100.00%> (+0.62%) ⬆️
unit 80.45% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot removed the type/chore Issue that requests non-user facing changes. label Dec 19, 2023
@jjbustamante jjbustamante marked this pull request as ready for review December 19, 2023 19:36
@jjbustamante jjbustamante requested review from a team as code owners December 19, 2023 19:36
jjbustamante and others added 2 commits December 19, 2023 15:56
to fix some errors on windows LCOW

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante merged commit 1749198 into main Dec 19, 2023
18 checks passed
@jjbustamante jjbustamante deleted the chore/issue-2005 branch December 19, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
2 participants