Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Retrieve SBoM from Registry for Remote Images #2020

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

sarthaksarthak9
Copy link
Contributor

@sarthaksarthak9 sarthaksarthak9 commented Jan 9, 2024

Summary

when attempting to download a (SBoM) from a remote image that is not present in the Docker daemon, the pack tool throws an error, forcing the user to download the image to the daemon before extracting SBoM information.

Output

Before

After

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #1615

@sarthaksarthak9 sarthaksarthak9 requested review from a team as code owners January 9, 2024 16:35
@github-actions github-actions bot added this to the 0.33.0 milestone Jan 9, 2024
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c08b289) 79.52% compared to head (d2c5a55) 79.52%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2020   +/-   ##
=======================================
  Coverage   79.52%   79.52%           
=======================================
  Files         174      174           
  Lines       13077    13077           
=======================================
  Hits        10398    10398           
  Misses       2016     2016           
  Partials      663      663           
Flag Coverage Δ
os_linux 78.43% <100.00%> (ø)
os_macos 76.22% <100.00%> (-0.02%) ⬇️
os_windows 78.90% <100.00%> (ø)
unit 79.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sarthaksarthak9
Copy link
Contributor Author

@natalieparellano pls, review this pr !!

Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for the PR @sarthaksarthak9 🙏🏼

I think you need to fix the DCO - can you sign-off your second commit?

@sarthaksarthak9
Copy link
Contributor Author

Looks good to me! Thank you for the PR @sarthaksarthak9 🙏🏼

I think you need to fix the DCO - can you sign-off your second commit?

srry for this :)

Signed-off-by: sarthak <sarthaknegi908@gmail.com>
Signed-off-by: sarthak <sarthaknegi908@gmail.com>
@jjbustamante jjbustamante merged commit 50bb26d into buildpacks:main Jan 16, 2024
18 checks passed
@jjbustamante jjbustamante mentioned this pull request Jan 16, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pack sbom download should be able to retrieve the SBoM from remote images
3 participants