Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump default lifecycle version & lifecycle library version 0.18.4 #2032

Merged
merged 4 commits into from
Jan 24, 2024

Conversation

jjbustamante
Copy link
Member

@jjbustamante jjbustamante commented Jan 23, 2024

Summary

Update to version 0.18.4

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
@jjbustamante jjbustamante requested review from a team as code owners January 23, 2024 14:33
@github-actions github-actions bot added type/enhancement Issue that requests a new feature or improvement. type/chore Issue that requests non-user facing changes. labels Jan 23, 2024
@github-actions github-actions bot added this to the 0.33.0 milestone Jan 23, 2024
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (038d3e7) 79.63% compared to head (011f6d3) 79.63%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2032   +/-   ##
=======================================
  Coverage   79.63%   79.63%           
=======================================
  Files         176      176           
  Lines       13199    13199           
=======================================
  Hits        10510    10510           
  Misses       2020     2020           
  Partials      669      669           
Flag Coverage Δ
os_linux 78.56% <100.00%> (ø)
os_macos 76.37% <100.00%> (ø)
os_windows 79.02% <100.00%> (ø)
unit 79.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

google.golang.org/protobuf v1.31.0 // indirect
gopkg.in/warnings.v0 v0.1.2 // indirect
gotest.tools/v3 v3.4.0 // indirect
)

go 1.21

// Pin moby/buildkit until docker/docker is upgraded
replace github.com/moby/buildkit => github.com/moby/buildkit v0.11.6
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had an error similar to this one, the way to workaround it was to pin the buildkit version similar to the lifecycle

@jjbustamante
Copy link
Member Author

@natalieparellano @jkutner could you give me your thoughts here 👀

@jjbustamante jjbustamante merged commit c6dd3ce into main Jan 24, 2024
18 checks passed
@jjbustamante jjbustamante deleted the deps/jjbustamante/update-to-lifecycle-0_18_4 branch January 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/chore Issue that requests non-user facing changes. type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants