Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose logging is not applied to analyze phase when publishing #419

Closed
philwebb opened this issue Dec 16, 2019 · 2 comments · Fixed by #636
Closed

Verbose logging is not applied to analyze phase when publishing #419

philwebb opened this issue Dec 16, 2019 · 2 comments · Fixed by #636
Assignees
@dfreilich
Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.

Comments

@philwebb
Copy link

The withLogLevel method is not applied to the "analyzer" phase that is created if publish is true. I believe that this this line should be wrapped in l.withLogLevel.
@philwebb
Copy link
Author

I also just noticed that it's also not applied to the build phase.

@jromero jromero added the status/triage Issue or PR that requires contributor attention. label Feb 5, 2020
@natalieparellano natalieparellano added the type/bug Issue that reports an unexpected behaviour. label Feb 5, 2020
@natalieparellano
Copy link
Member

Possible acceptance criteria:

When I run pack build with --publish
And I inspect the output
Then I should see verbose logging from analyzer (not sure exactly what verbose logging looks like but we could add it later)
And I should see verbose logging from build

@natalieparellano natalieparellano added good first issue A good first issue to get started with. status/ready Issue ready to be worked on. and removed status/triage Issue or PR that requires contributor attention. labels Feb 5, 2020
@natalieparellano natalieparellano mentioned this issue Feb 5, 2020
Closed
@dfreilich dfreilich self-assigned this May 18, 2020
@dfreilich dfreilich mentioned this issue May 19, 2020
Merged
@jromero jromero closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfreilich dfreilich

Labels
good first issue A good first issue to get started with. status/ready Issue ready to be worked on. type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add verbose logging to Analyze and Build phases buildpacks/pack
4 participants
@jromero @philwebb @natalieparellano @dfreilich