Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Image Creation Date Metadata #70

Closed
nebhale opened this issue Nov 8, 2018 · 6 comments
Closed

Missing Image Creation Date Metadata #70

nebhale opened this issue Nov 8, 2018 · 6 comments
Milestone

Comments

@nebhale
Copy link
Contributor

nebhale commented Nov 8, 2018

Currently, when I create an image using pack build, the docker image command reports that the image is 292 years old (last line):

hypnotoad: docker images
REPOSITORY                      TAG                 IMAGE ID            CREATED             SIZE
golang                          latest              d817ad5b9beb        5 days ago          774MB
packs/run                       0.0.1-rc.259        13df6da62128        2 weeks ago         160MB
localhost:5000/run              0.0.1-rc.259        13df6da62128        2 weeks ago         160MB
localhost:5000/run              0.0.1-rc.258        54413ee93b68        2 weeks ago         160MB
packs/run                       0.0.1-rc.258        54413ee93b68        2 weeks ago         160MB
localhost:5000/builder          <none>              f6bc8ff8a841        2 weeks ago         674MB
localhost:5000/builder          latest              ac7e0fa41e38        2 weeks ago         674MB
packs/build                     latest              8b41724a4c36        2 weeks ago         160MB
localhost:5000/build            latest              8b41724a4c36        2 weeks ago         160MB
registry                        latest              2e2f252f3c88        8 weeks ago         33.3MB
localhost:5000/app-uncompiled   latest              e5f52db674d4        292 years ago       303MB

I don't really know anything about the OCI image spec, but I suspect that there's some missing creation date metadata. It'd be nice if that was accurate.

@jchesterpivotal
Copy link
Contributor

This is almost definitely some sort of underflow. -292 years is approximately -9.2 quintillion nanoseconds and the range of a golang int64 is approximately ± 9.2 quintillion.

@nebhale nebhale changed the title Missing Image Creation Data Metadata Missing Image Creation Date Metadata Nov 9, 2018
@ekcasey ekcasey added this to Icebox in Planning Board via automation Dec 12, 2018
@ekcasey ekcasey moved this from Icebox to Backlog in Planning Board Dec 12, 2018
@ekcasey
Copy link
Member

ekcasey commented Dec 12, 2018

@nebhale added to the backlog

@nebhale nebhale closed this as completed Dec 13, 2018
@nebhale nebhale reopened this Dec 13, 2018
@nebhale
Copy link
Contributor Author

nebhale commented Dec 13, 2018

Still having the issue:

$: docker images
REPOSITORY                           TAG                 IMAGE ID            CREATED             SIZE
localhost:5000/uncompiled            <none>              72bda8a5c7f0        3 hours ago         310MB
localhost:5000/run                   0.0.1-rc.440        5d79af41489c        3 hours ago         161MB
localhost:5000/run                   v3alpha2            5d79af41489c        3 hours ago         161MB
localhost:5000/uncompiled            <none>              48c0c0614468        3 hours ago         310MB
localhost:5000/build                 v3alpha2            a7f5bfd379bd        3 hours ago         161MB
localhost:5000/builder-open-source   latest              82439e455dc7        3 hours ago         668MB
localhost:5000/builder-commercial    latest              62aa84fb413f        3 hours ago         671MB
localhost:5000/uncompiled            latest              f5ffab0c4789        292 years ago       310MB

Wonder if it has anything to do with the second staging on the same image name?

@ekcasey ekcasey moved this from Backlog to Done in Planning Board Mar 28, 2019
@mgibson1121
Copy link
Member

@sclevine @ekcasey Any particular steps to reproduce this? Not seeing this error on my pack builds when I run docker images using pack ```pack-0.1.0-build.74-darwin`` (however, me not seeing the error in my docker images doesn't mean it's fixed)

@ekcasey
Copy link
Member

ekcasey commented Apr 1, 2019

The error incorrect creation date used to be visible after

  1. running a build with --publish
  2. pulling the image with docker pull
  3. listing images (docker images)

@mgibson1121
Copy link
Member

LGTM accepting/

@mgibson1121 mgibson1121 moved this from Done to Release v0.1.0 in Planning Board Apr 1, 2019
@sclevine sclevine closed this as completed Apr 3, 2019
@jromero jromero added this to the 0.1.0 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants