Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pack build fails when app directory is symlinked #93

Closed
jldec opened this issue Jan 29, 2019 · 2 comments · Fixed by #165
Closed

pack build fails when app directory is symlinked #93

jldec opened this issue Jan 29, 2019 · 2 comments · Fixed by #165
Labels
type/bug Issue that reports an unexpected behaviour.
Milestone
0.2.0

Comments

@jldec
Copy link

jldec commented Jan 29, 2019

running pack compiled from master

~/riff/squared$ ls -l ../squared
lrwxr-xr-x  1 joeuser  staff  15 Jan 23 12:55 ../squared -> node-fun-square

~/riff/squared$ ~/pack/pack build myrepo/foo:v1 --builder $PFS_BUILDER_IMAGE --run-image $PFS_PACKS_RUN_IMAGE

Defaulting app directory to current working directory /Users/joeuser/riff/squared (use --path to override)

...

===> DETECTING

ERROR: copy app to workspace volume: Error response from daemon: Error processing tar file(exit status 1): cannot overwrite directory "/workspace/app" with non-directory "/"
@ekcasey ekcasey added the type/bug Issue that reports an unexpected behaviour. label Mar 11, 2019
@ekcasey ekcasey added this to Icebox in Planning Board via automation Apr 2, 2019
@ekcasey ekcasey moved this from Icebox to Backlog in Planning Board Apr 2, 2019
@jromero jromero mentioned this issue Apr 19, 2019
Merged
@ekcasey ekcasey moved this from Backlog to Done in Planning Board May 6, 2019
@ekcasey ekcasey added the v0.2.0 label May 6, 2019
@mgibson1121
Copy link
Member

Needs @sclevine, don't know how to reproduce a symlinked app directory

@mgibson1121 mgibson1121 added help wanted Need some extra hands to get this done. Help Accepting and removed help wanted Need some extra hands to get this done. labels May 10, 2019
@mgibson1121
Copy link
Member

This story passes acceptance

@mgibson1121 mgibson1121 moved this from Done to Release v0.2.0 in Planning Board May 14, 2019
@jromero jromero added this to the 0.2.0 milestone Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Issue that reports an unexpected behaviour.
Projects
None yet
Milestone
0.2.0
Development

Successfully merging a pull request may close this issue.

Resolve symbolic links for app dir jromero/pack
4 participants
@jromero @jldec @ekcasey @mgibson1121