Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

As a developer, pack build exits cleanly and quickly on ctrl-c when an image is pulling #49

Closed
sclevine opened this issue Feb 4, 2019 · 2 comments

Comments

@sclevine
Copy link
Member

sclevine commented Feb 4, 2019

Acceptance Criteria
When I pack build
And An image starts pulling
And I ctrl-c
Then It exits immediately
And I don't observe network traffic

@ekcasey
Copy link
Member

ekcasey commented Mar 14, 2019

It seems like this works now that the pull logic has been pulled into pack but it does print a fairly raw (ugly?) error. Are we okay we this? If not what do we want it to look like?

./pack build -p ./acceptance/testdata/node_app/ --builder gcr.io:443/cncf-buildpacks-ci/packs/samples:3.0.0-alpha.3-build.14 node/app
Using user-provided builder image gcr.io:443/cncf-buildpacks-ci/packs/samples:3.0.0-alpha.3-build.14
Pulling builder image gcr.io:443/cncf-buildpacks-ci/packs/samples:3.0.0-alpha.3-build.14 (use --no-pull flag to skip this step)
^CERROR: error during connect: Post http://%!F(MISSING)var%!F(MISSING)run%!F(MISSING)docker.sock/v1.38/images/create?fromImage=gcr.io%!A(MISSING)443%!F(MISSING)cncf-buildpacks-ci%!F(MISSING)packs%!F(MISSING)samples&tag=3.0.0-alpha.3-build.14: context canceled

@ekcasey ekcasey moved this from Backlog to Done in Planning Board Mar 14, 2019
@mgibson1121
Copy link
Member

This story passes acceptance

@mgibson1121 mgibson1121 moved this from Done to Release v0.1.0 in Planning Board Mar 14, 2019
@sclevine sclevine closed this as completed Apr 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants