Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved CPU Compatibility detection #32

Closed
Belim opened this issue Jul 15, 2021 · 8 comments
Closed

Improved CPU Compatibility detection #32

Belim opened this issue Jul 15, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@Belim
Copy link
Member

Belim commented Jul 15, 2021

check latest testing build #20 and give feedback

  • moved all supported cpus (intel, amd, qualcomm) into one resource file
  • maybe a milisecond faster detection Using StreamReader.ReadLine!?
  • reference file generated in output dir of app (temp dir, localappdir?)
@Belim Belim added the enhancement New feature or request label Jul 15, 2021
@Oleg-Chashko
Copy link
Contributor

  • moved all supported cpus (Intel, AMD, Qualcomm) into one resource file -> If, you are comfortable with that, it's a good idea.
  • maybe a millisecond faster detection Using StreamReader.ReadLine!? -> If, you are comfortable with that, it's a good idea. I didn't notice the difference. :)
  • reference file generated in output dir of app (temp dir, localappdir?) -> In the future, this File should be in the temp folder. Where the file "(dxv)-> (rsv)" is now in the temp folder.

Fixed (corrected) File "supportedCPU" (Microsoft made typos in the names of processors). I corrected the same Microsoft errors in another project.

Fixed_supportedCPU.zip

@Belim
Copy link
Member Author

Belim commented Jul 15, 2021

for reference i will push the file within the app install directory. some would like to know how the matching is made.

i have also thought about an online sync, but you once told me that not everyone has internet or good internet, so discarded that again 😄

@Belim
Copy link
Member Author

Belim commented Jul 15, 2021

many thanks for the fixed file version 🤝 💯

@Oleg-Chashko
Copy link
Contributor

many thanks for the fixed file version 🤝 💯

Glad to have helped.😄

@Oleg-Chashko
Copy link
Contributor

for reference i will push the file within the app install directory. some would like to know how the matching is made.

How to do it right: this file (supportedCPU) should be in the temp folder. And if the user wants to see compatible processors, he clicks the button in your program, a window opens and in a clear form displays Processors and Graphics cards that are compatible with Windows 11.

The same thing I suggested in another project.

P.S.: Try to regroup from the silly ideology of Windows. (Clutter up with files, all the space around you.) :(

@Oleg-Chashko
Copy link
Contributor

I moved my suggestions for improvement to the topic "Improving the user interface".
If you want, can you close this topic.

@Belim
Copy link
Member Author

Belim commented Jul 15, 2021

yep, let's get here going #22

@Belim Belim closed this as completed Jul 15, 2021
@epman100
Copy link

epman100 commented Sep 2, 2021

check latest testing build #20 and give feedback

* moved all supported cpus (intel, amd, qualcomm) into one resource file

needs another update as MS recently added a few more supported Intel CPUs (a few 7th gen Intel processors) as noted by this MS blog published Aug. 27

"We did identify a set of PC models that meet the principles while running on Intel 7th Gen processors that we did not originally include in our minimum system requirements."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants