Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AroonIndicator from trend.py based on inadequate input #315

Closed
jennerwein opened this issue Feb 17, 2023 · 2 comments
Closed

AroonIndicator from trend.py based on inadequate input #315

jennerwein opened this issue Feb 17, 2023 · 2 comments

Comments

@jennerwein
Copy link

The AroonIndicator in trend.py uses close(pandas.Series) as price data input.
But the indicator arron_up() is based on N-day high. This means that arron_up() should use high(pandas.Series) as input and not close data.
Accordingly, arron_down() should use low(pandas.Series).

This means that AroonIndicator should have two pandas.Series as input (Args): high(pandas.Series) as well as low(pandas.Series).
@jennerwein jennerwein mentioned this issue Feb 17, 2023
Open
@jennerwein
Copy link
Author

I solved this issue in pull request #316.

@bukosabino
Copy link
Owner

Hi @jennerwein,

The last version of the library (0.10.3) implements these changes.

Thank you all!

Best,
Dario

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bukosabino @jennerwein