Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: steampy.exceptions.ConfirmationExpected #255

Closed
Vindicty opened this issue Apr 6, 2023 · 10 comments
Closed

Error: steampy.exceptions.ConfirmationExpected #255

Vindicty opened this issue Apr 6, 2023 · 10 comments

Comments

@Vindicty
Copy link

Vindicty commented Apr 6, 2023

Hello guys, recently I started getting ConfirmationExpected error while trying to make offer with url with make_offer_with_url method. It's strage because few days ago it worked well and I didn't change my code. Please help,
Here a bit more details of error:

File "C:\Python\Python39\lib\site-packages\steampy\client.py", line 26, in func_wrapper
return func(self, *args, **kwargs)
File "C:\Python\Python39\lib\site-packages\steampy\client.py", line 313, in make_offer_with_url
response.update(self._confirm_transaction(response['tradeofferid']))
File "C:\Python\Python39\lib\site-packages\steampy\client.py", line 211, in _confirm_transaction
return confirmation_executor.send_trade_allow_request(trade_offer_id)
File "C:\Python\Python39\lib\site-packages\steampy\confirmation.py", line 38, in send_trade_allow_request
confirmation = self._select_trade_offer_confirmation(confirmations, trade_offer_id)
File "C:\Python\Python39\lib\site-packages\steampy\confirmation.py", line 100, in _select_trade_offer_confirmation
raise ConfirmationExpected
steampy.exceptions.ConfirmationExpected

@woctezuma
Copy link

woctezuma commented Apr 6, 2023

That means you did not get any confirmation.

def _select_trade_offer_confirmation(self, confirmations: List[Confirmation], trade_offer_id: str) -> Confirmation:
for confirmation in confirmations:
confirmation_details_page = self._fetch_confirmation_details_page(confirmation)
confirmation_id = self._get_confirmation_trade_offer_id(confirmation_details_page)
if confirmation_id == trade_offer_id:
return confirmation
raise ConfirmationExpected

Check your credentials, I guess.

@Vindicty
Copy link
Author

Vindicty commented Apr 6, 2023

I'm checking online status with method is_session_alive and it returns True

@d0nker420
Copy link

Hey, I'm getting the same error despite there being an active confirmation visible via another steam library. @Vindicty did you manage to resolve this issue?

@wizzzz9
Copy link

wizzzz9 commented Jun 3, 2023

It seems that something has changed, I'm already looking for some fix
If I can do that, I'll let you know

@SamuelKollar
Copy link

Any updates on this issue ? I am getting the same error and I can see that the trade has been created, it is just not accepted.

@d0nker420
Copy link

d0nker420 commented Jul 10, 2023

Any updates on this issue ? I am getting the same error and I can see that the trade has been created, it is just not accepted.

@SamuelKollar @wizzzz9 see my reply here: #210 (comment).

@SamuelKollar
Copy link

I looked at the reply, I checked assetid type which is string and changed the parser to a different one but I am still getting the same error, after I removed the exception I get this :

in confirmation.py, line 50, in _send_confirmation
params['cid'] = confirmation.data_confid
AttributeError: 'NoneType' object has no attribute 'data_confid'

Any idea as of what might be causing it ?

@Anunah9
Copy link

Anunah9 commented Jul 23, 2023

The problem is in the def _fetch_confirmations_page(self) function in the response = self._session.get(self.CONF_URL + '/conf', params=params, headers=headers) line. Status response code 404. Perhaps something has changed with the Steam update and now confirmations work differently

@SamuelKollar
Copy link

Yeah, because params['cid'] = confirmation.data_confid is none, thats why the url does not return a valid response, the issue is in _get_confirmations() on the line: soup = BeautifulSoup(confirmations_page.text, 'html.parser'), I tried changing up html.parser for html5lib but nothing changed

@bukson
Copy link
Owner

bukson commented Sep 14, 2023

Should be fixed with #274

@bukson bukson closed this as completed Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants